Repository navigation
Conversation
- Add source_code_uri, bug_tracker_uri, and rubygems_mfa_required metadata - Build the file list with Dir instead of shelling out to git, so the gem builds outside a git checkout (the packaged files are unchanged) - Use https for the Gemfile source Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
source_code_uriandbug_tracker_uri, so rubygems.org links to the repo and issues. Addsrubygems_mfa_required = 'true', so future releases must be pushed with MFA, which protects against supply-chain attacks.gem.fileswithDirinstead of shelling out togit ls-files. The gem now builds outside a git checkout, for example from a source tarball or in some packaging pipelines. I checked that the packaged file list is identical: every file underlib/is.rb, plusREADME.mdandLICENSE.https://for theGemfilesource. Thehttp://source allowed gems to be fetched over plain HTTP.Authors and emails are unchanged.
Testing
gem build docker-api.gemspecsucceeds.git ls-files lib README.md LICENSEand the newDirglob produce the same file list.