Repository navigation
Conversation
- Delete script/docker and script/docker.conf, a SysV init script and upstart config that nothing references since Travis CI was removed - Drop the /opt/docker PATH hack in the Rakefile, also a Travis leftover - Replace swipely/base and tianon/true with hello-world in specs and the unpack task. Both old images are amd64-only and unmaintained; hello-world is tiny and multi-arch, so the suite runs on arm64 hosts - Update the TESTING.md prerequisites Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes files and settings left over from Travis CI, and replaces two unmaintained test images.
script/dockerandscript/docker.conf. They're a SysV init script and an upstart config for running the daemon on the old Travis hosts. Nothing has referenced them since Travis was removed./opt/dockerPATHhack in theRakefile. It's also a Travis leftover; GitHub Actions installs Docker from apt.swipely/baseandtianon/truewithhello-worldin the specs and theunpacktask. Both old images are amd64-only (tianon/truewon't even pull on arm64:no matching manifest for linux/arm64/v8) and haven't been maintained in years.hello-worldis ~10 KB, multi-arch, and maintained by Docker, so the suite now runs on arm64 hosts such as Apple Silicon.Container#exportnow runs/helloinstead of/true.TESTING.mdprerequisites. They still said Ruby 1.9+ and Docker 1.3.1.Unchanged on purpose:
spec/fixtures/load.tar(a savedtianon/trueimage) and thetianon_true.tarimport URL.docker loadandimportdon't depend on the host architecture, and the S3 URL still returns 200.tianon/truestrings inevent_spec. They're mocked event payloads, not images that get pulled.