Skip to content

discovery/*: Revamping the discovery stack#85

Merged
AlexisMontagne merged 8 commits into
masterfrom
am-discovery-update
Apr 16, 2026
Merged

discovery/*: Revamping the discovery stack#85
AlexisMontagne merged 8 commits into
masterfrom
am-discovery-update

Conversation

@AlexisMontagne
Copy link
Copy Markdown
Member

What does this PR do?

This PR is a major refactor, bug fix and improvement of the discovery stack.

The goal is to help leveraging UDS runtime updates in a better way.

What are the observable changes?

Good PR checklist

  • Title makes sense
  • Is against the correct branch
  • Only addresses one issue
  • Properly assigned
  • Added/updated tests
  • Added/updated documentation
  • Properly labeled

Additional Notes

@AlexisMontagne AlexisMontagne self-assigned this Apr 14, 2026
@AlexisMontagne AlexisMontagne requested a review from a team as a code owner April 14, 2026 20:07
@AlexisMontagne AlexisMontagne requested review from pauloestrella1994 and xgoffin and removed request for a team April 14, 2026 20:07
Copy link
Copy Markdown
Contributor

@xgoffin xgoffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a lot of this code doesn't respect our usual coding guidelines in terms of linebreaks before/after blocks. Could you give it a style cleanup please? 🙏 Listed a few examples

Comment thread discovery/balancer/roundrobin/balancer_test.go Outdated
Comment thread discovery/balancer/simple/policy.go
Comment thread discovery/balancer/simple/policy.go
@AlexisMontagne AlexisMontagne merged commit f13adac into master Apr 16, 2026
4 checks passed
@AlexisMontagne AlexisMontagne deleted the am-discovery-update branch April 16, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants