improve settings and modal mobile designs#668
Open
Elodie-DeMatteis-Upf wants to merge 1 commit into
Open
Conversation
Elodie-DeMatteis-Upf
force-pushed
the
edm/pyx-105
branch
from
8342cd4 to
c3ace03
Compare
Elodie-DeMatteis-Upf
force-pushed
the
emd/pyx-111
branch
from
d83c0b2 to
e9b8579
Compare
nathalieArnoux
approved these changes
May 20, 2026
aprentout
reviewed
May 20, 2026
| flex: 1; | ||
| padding-right: var(--spacing-px-60); | ||
| padding-bottom: var(--spacing-px-24); | ||
| padding-bottom: var(--spacing-px-18); |
Contributor
There was a problem hiding this comment.
For reviewers, this should have no negative impact on "upfluence-web" as padding-bottom is used on mobile view only
aprentout
approved these changes
May 20, 2026
JulienVannier66
approved these changes
May 20, 2026
Miexil
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
On mobile/very small screens, modals now have a max height to 90vh instead of a fixed height.
Bottom padding of split settings content has been reduced from 24px to 18px to reduce lost space on mobile screens.
Related to: #
What are the observable changes?
Good PR checklist