[CC-1085] Mark Giropay payment type as deprecated. - #187
Merged
Conversation
Ryouzanpaku
force-pushed
the
CC-1085/deprecate-giropay
branch
from
February 11, 2026 08:40
9602c23 to
a589a63
Compare
Ryouzanpaku
force-pushed
the
CC-1085/deprecate-giropay
branch
from
February 11, 2026 09:52
a589a63 to
01b614a
Compare
NiushaGhanbari
approved these changes
Feb 11, 2026
sixer1182
added a commit
that referenced
this pull request
Sep 9, 2026
SofortTest.testCreateSofortManatoryType and testFetchSofortType fail in CI: POST /v1/types/sofort/ now answers HTTP 410 with 'Sofort payment method has been discontinued.', so the two remaining enabled tests in the class can never pass again. The third test was already @disabled('does not work on PAPI'). Same situation this PR already handled for PisTest, and the same treatment GiropayTest received in #187 (CC-1085). Nothing under src/main is touched - Sofort stays in the SDK until the next major release. The two other Sofort references, ChargeTest.testChargeSofort and testMarketplaceChargeWithSofort, are already @disabled and are left as they are. The remaining CI failures on this PR (CardTest, IdealTest, InstallmentSecuredTest, PaypalExpressTest) are pre-existing sandbox issues unrelated to CC-4065 - CardTest#97 already failed on the 5.9.0 release PR in February. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011GTcoUbc5ziRDHgWV3hgzQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.