Merged
Conversation
add admission gates, enforce texture policy, and fix memory budgeting
When a USDZ texture had no bracket-notation path, `uniqueURL` fell back to the name-based stable URL (e.g. "usdz-embedded://scene.usdz/embedded_Basecolor_map"). BatchingSystem.normalizeTextureURL stripped the asset-scope host, collapsing every unnamed texture from the same USDZ to the same token. All entities then hashed to the same BatchBuildKey and were merged into one batch group whose representative material was only the first entity's GPU texture — every other entity rendered with the wrong texture. Fix: mirror cacheKeyURL — use objectIdentityURL when no bracket path is found. Same MDLTexture pointer = same physical texture = share GPU cache + batch group. Different pointers = different textures = separate batch groups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This release implements out-of-core in the engine