Repository navigation
feat: comment from the pr overview, and fix thread collapse in the diff - #57
Merged
Merged
Conversation
github does not thread conversation comments, so gp only offers a reply on a code thread box; ga answers everything else with a new comment on the pr.
…indent the reply count now means one thing in both views: replies you cannot see. the wrap indent moves to breakindentopt=list:-1 so it applies per line, since shift:2 indented plain prose that has no spine to clear.
an override outranks the cursor, so it has to stop outranking it once the cursor has gone; otherwise dismissing one peek opts that thread out for the session, with no third press to get the default back.
split has no choice but the marker and float surface, so a config of expanded was treated there as having no cursor-driven default, and a gc override on it never lapsed.
github doesn't thread these, so gp answers one with a new comment that quotes what it answers; the visual variant quotes the selection alone, which is the part a cursor buys over github's whole-comment quote.
the cursor decides where an answer goes and the key decides whether it quotes, so neither has to explain the other; gq inside an expanded thread quotes the reply the cursor is on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gais a standard comment on the pr,gp/gqboth answerthe comment/thread under the cursor, but
gq(andv_gqfor visual mode) quote from the respectivecomment/thread
gcnow shows or hides a thread's repliespost_issue_commentsidecar method over graphqladdCommentui.overviewrecords a node id per thread and a row span per rendered commentwould otherwise still show the pre-reply thread
breakindentopt=list:-1andformatlistpat, which reads a lot bettergcin the diff released its override only on teardown, opting a thread out ofpeeking for the session with no way back; it now lapses as soon as the cursor leaves the anchor
thread_collapsedread the configured display mode rather than the one a split layoutforces, so
expandedplus split kept the same stuck overrideui.composelands the cursor past a prefill, which also fixes the conflict re-promptputting you above your own body
Test plan
make checkandmake gql-validateboth clean