Repository navigation
fix: respect the cursorline option across the pr surfaces - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cursorline._paint_cursorlinenow reads the window's effective value and returns early when it's offcursorlinemid-session left the tint on its last paint until the next cursor move; anOptionSetautocmd repaints on the spotcursorlineoff, so acursorlineuser lost it; it now mirrorsvim.go.cursorlinecursorlinethrough a barevim.wo[win], which writes the global too, switching the cursor line on for the rest of the session. it now goes throughutil.win.set_locallike the other surfacescursorline_tint's config comment said it "allows the cursorline to inherit" the highlights; it now says the tint is only drawn whencursorlineis ong?cheatsheet and its two keymap comments used "review" for both the review screen and a github pending review, soeandrread as the same key.eis now enter,ris enter + start a draft reviewTest plan
make checkclean