Skip to content

fix: respect the cursorline option across the pr surfaces - #56

Merged
undont merged 3 commits into
mainfrom
fix/respect-cursorline
Sep 7, 2026
Merged

undont merged 3 commits into
mainfrom
fix/respect-cursorline

Conversation

@undont

@undont undont commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • the diff painted its own cursor-line tint regardless of cursorline. _paint_cursorline now reads the window's effective value and returns early when it's off
  • toggling cursorline mid-session left the tint on its last paint until the next cursor move; an OptionSet autocmd repaints on the spot
  • the PR overview hardcoded cursorline off, so a cursorline user lost it; it now mirrors vim.go.cursorline
  • the PR checks float set cursorline through a bare vim.wo[win], which writes the global too, switching the cursor line on for the rest of the session. it now goes through util.win.set_local like the other surfaces
  • cursorline_tint's config comment said it "allows the cursorline to inherit" the highlights; it now says the tint is only drawn when cursorline is on
  • the overview's g? cheatsheet and its two keymap comments used "review" for both the review screen and a github pending review, so e and r read as the same key. e is now enter, r is enter + start a draft review

Test plan

  • make check clean

@undont
undont merged commit 7ead6b4 into main Sep 7, 2026
11 checks passed
@undont
undont deleted the fix/respect-cursorline branch September 7, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant