Repository navigation
fix: diff a renamed pr file against its previous path - #55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetFileVersionsfetched one path at both refs, so the new path 404'd at the base sha and came backMissing: true, which reached the model as an empty old side;GetFileVersionsnow takes a base path beside the head pathget_file_versionsgains an optionalprevious_path, which the sidecar has read off the REST file list intoPRFile.PreviousPathall along but wasn't usedclient.get_file_versionstakes the file entry rather than a bare path, matchinggit.model's{ path, previous_path }on the local side(owner, repo, ref, path), so the two sides cache separately with no changelua/monokai.lua->lua/dracula.lua), the easiest way to eyeball this offlineTest plan
make checkclean