Undo v1.26.0 #52
Draft
Undo v1.26.0 #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Undo, debuggee state is immutable during replay, so reading the G pointer via code injection won't work; and in any case, this approach is simpler.
* Update the documentation to mention UDB or LiveRecorder alongside rr. * Add makefile support for testing the Undo backend. * Add DLV_RECORD_REPLAY_BACKEND environment variable which overrides the record-replay backend, for use in GoLand. * Implement checkpoints as a map from checkpoint number to time. * Suppress resume call after restart. * Implement "when" command using "get_time" serial command. * Implement call injection using "set_debuggee_volatile". * Implement "restart" using "goto_time". * Enable or disable Undo backend appropriately in test cases.
This allows a separate debug symbol file to be specified when replaying a recording with the Undo backend. This can be used to supply debug information when the main binary has been stripped.
The error handling here was a bit painful but only needs doing in these two places (for now).
This is made compatible with UDB's bookmarks by using the UDB bookmark name as the "Note" field in Delve. To save Delve checkpoints, the "Note" must be made unique, so as to be a valid bookmark name in UDB.
Since we added support for a process tree level UUID the `vUDB;get_recording_ids` serial protocol message can return 4 UUIDs. It's easiest to just handle this unconditionally for now, we can clean up the legacy support later.
UDB now saves some additional paths to the session file. We don't do anything with these paths, but we need to be aware of them.
mark-undoio
reviewed
Jan 28, 2026
Contributor
mark-undoio
left a comment
mark-undoio
left a comment
There was a problem hiding this comment.
Some very minor comments.
I take it we didn't need to materially change how our patches work as part of this port? Was there anything unusual required in the rebase?
service/test/integration1_test.go
Outdated
| @@ -0,0 +1,1096 @@ | |||
| package service_test | |||
Contributor
There was a problem hiding this comment.
I think we've resurrected a test here because we used to have renaming in it. Possibly it's related to the deprecated (or removed?) RPC protocol version 1.
I suspect we can drop it (thought I'd caught all these before but probably I did not)
service/test/integration1_test.go
Outdated
| @@ -1,1096 +0,0 @@ | |||
| package service_test | |||
Contributor
There was a problem hiding this comment.
And here we've deleted it! It looks like this is a result of me fixing it up badly last time.
| golang.org/x/exp/constraints | ||
| golang.org/x/exp/maps | ||
| golang.org/x/exp/slices | ||
| # golang.org/x/mod v0.20.0 |
Contributor
There was a problem hiding this comment.
Did we intend to add these (and their associated license files)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request represents the differences between upstream Delve v1.26.0, and our fork at the same version. It is for review and not for merge.