Draft
Conversation
gareth-rees
approved these changes
May 24, 2023
Contributor
gareth-rees
left a comment
gareth-rees
left a comment
There was a problem hiding this comment.
This looks fine to me, though obviously it is difficult to review thoroughly. I noted a few places where the diff could be simplified.
Contributor
Author
|
Thanks. I'm going to go investigate the disagreement between my Perhaps updating my Go (I'm on 1.18) will help, though I'm a bit surprised if they've decided to change their formatting as part of a version update. |
In Undo, debuggee state is immutable during replay, so reading the G pointer via code injection won't work; and in any case, this approach is simpler.
* Update the documentation to mention UDB or LiveRecorder alongside rr. * Add makefile support for testing the Undo backend. * Add DLV_RECORD_REPLAY_BACKEND environment variable which overrides the record-replay backend, for use in GoLand. * Implement checkpoints as a map from checkpoint number to time. * Suppress resume call after restart. * Implement "when" command using "get_time" serial command. * Implement call injection using "set_debuggee_volatile". * Implement "restart" using "goto_time". * Enable or disable Undo backend appropriately in test cases.
Contributor
Author
|
@gareth-rees if you'd like to check my updates, feel free. Passes the local Delve tests I ran before, so I'll run it against my end-to-end tests too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request represents the differences between upstream Delve v1.20.2, and our fork at the same version. It is for review and not for merge.