fix(content-filter): honor preserve whitelist for excluded tags - #2126
Open
bong-u wants to merge 1 commit into
Open
fix(content-filter): honor preserve whitelist for excluded tags#2126bong-u wants to merge 1 commit into
bong-u wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2125
_remove_unwanted_tagsdecomposed by tag name, sopreserve_tagsandpreserve_classesnever reached elements whose tag is inexcluded_tags.It now iterates elements and skips the ones
_is_preserved()matches, so both whitelists go through the guard that already existed.This changes semantics for
scriptandstyle, which are inexcluded_tagstoo:preserve_tags=["script"]now really keeps them.A user has to name the tag to get that, so I did not special-case it.
List of files changed and why
crawl4ai/content_filter_strategy.py- filter by element instead of tag name in_remove_unwanted_tagsso the whitelist is consulted; docstring updated to say the whitelist also overridesexcluded_tags.tests/test_pruning_preserve_whitelist_1900.py- the oldtest_whitelist_does_not_override_excluded_tagsasserted nothing and documented the bug as expected, so I inverted it, and added a case for a whitelisted class on an excluded tag.How Has This Been Tested?
pytest tests/test_pruning_preserve_whitelist_1900.py- 21 passed.Checklist: