fix: Docker Redis CVE-2025-49844 — fix build failures and version pinning (#1671)#1846
Closed
hafezparast wants to merge 1 commit intounclecode:developfrom
Closed
fix: Docker Redis CVE-2025-49844 — fix build failures and version pinning (#1671)#1846hafezparast wants to merge 1 commit intounclecode:developfrom
hafezparast wants to merge 1 commit intounclecode:developfrom
Conversation
…ning (unclecode#1671) The previous Redis CVE fix on develop had three issues: 1. curl/gnupg used before being installed (build failure on slim image) 2. redis-tools not pinned alongside redis-server (apt dependency conflict) 3. Packages not held, so playwright install --with-deps upgraded Redis to 8.x Now installs curl/gnupg first, pins both redis-server and redis-tools to 7.2.13, and uses apt-mark hold to prevent subsequent upgrades. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
Thank you for your contribution, this is already fixed and it's in the latest Docker image: 0.8.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl/gnupgare used to add the Redis apt repo before they're installed (breaksdocker buildonpython:3.12-slim-bookworm)redis-toolsis not pinned alongsideredis-server(causes apt dependency conflict)playwright install --with-depsupgrades Redis back to 8.xChanges
Dockerfile:curlandgnupgbefore Redis repo setupredis-toolsto same version asredis-serverapt-mark hold redis-server redis-toolsto prevent upgrades7.2.13(latest 7.2.x patch)Verified locally
Test plan
tests/test_issue_1671_redis_cve.py(10 tests)playwright install --with-depsGenerated with Claude Code