fix: replace items prop with ListItem children in homepage Select and ComboBox#12
Open
Bhavysinghal wants to merge 1 commit into
Open
fix: replace items prop with ListItem children in homepage Select and ComboBox#12Bhavysinghal wants to merge 1 commit into
Bhavysinghal wants to merge 1 commit into
Conversation
|
@Bhavysinghal is attempting to deploy a commit to the Umami Software Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #11
The
SelectandComboBoxcomponents on the homepage (index.mdx) were using anitemsprop that doesn't exist on either component. This caused both dropdowns to render with no options and not respond to clicks.Why
The
SelectandComboBoxcomponents from@umami/react-zenexpect<ListItem>elements as children — not anitemsarray prop. Passing an unsupported prop silently did nothing, leaving the dropdowns empty.Fix
Replaced the
itemsprop with proper<ListItem>children on both components inapps/docs/content/index.mdx.Before
After
How to test
pnpm --filter react-zen-docs devhttp://localhost:9001Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.