Skip to content

fix: replace items prop with ListItem children in homepage Select and ComboBox#12

Open
Bhavysinghal wants to merge 1 commit into
umami-software:masterfrom
Bhavysinghal:fix/select-demo-dropdown
Open

fix: replace items prop with ListItem children in homepage Select and ComboBox#12
Bhavysinghal wants to merge 1 commit into
umami-software:masterfrom
Bhavysinghal:fix/select-demo-dropdown

Conversation

@Bhavysinghal

@Bhavysinghal Bhavysinghal commented Jun 11, 2026

Copy link
Copy Markdown

What

Fixes #11

The Select and ComboBox components on the homepage (index.mdx) were using an items prop that doesn't exist on either component. This caused both dropdowns to render with no options and not respond to clicks.

Why

The Select and ComboBox components from @umami/react-zen expect <ListItem> elements as children — not an items array prop. Passing an unsupported prop silently did nothing, leaving the dropdowns empty.

Fix

Replaced the items prop with proper <ListItem> children on both components in apps/docs/content/index.mdx.

Before

image

After

image image

How to test

  1. Run pnpm --filter react-zen-docs dev
  2. Go to http://localhost:9001
  3. Click the Country select → dropdown now shows: United States, United Kingdom, Canada, Australia
  4. Click the Framework combobox → dropdown now shows: React, Vue, Angular, Svelte

View with Codesmith Autofix with Codesmith
Need help on this PR? Tag /codesmith with what you need. Autofix is disabled.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

@Bhavysinghal is attempting to deploy a commit to the Umami Software Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Zen UI Select component does not display in Demo

1 participant