Skip to content

Fix skills and agents JSON success status#3101

Closed
Yeachan-Heo wants to merge 1 commit into
mainfrom
fix/roadmap-458-skills-agents-status
Closed

Fix skills and agents JSON success status#3101
Yeachan-Heo wants to merge 1 commit into
mainfrom
fix/roadmap-458-skills-agents-status

Conversation

@Yeachan-Heo
Copy link
Copy Markdown
Contributor

Summary

  • add top-level status: "ok" to successful skills list/install JSON envelopes
  • add top-level status: "ok" to successful agents list JSON envelopes
  • add focused Rust assertions for skills/agents list/help/install JSON status contracts

Verification

  • cargo fmt
  • cargo test -p commands
  • cargo build -p rusty-claude-cli --bin claw
  • rebuilt acceptance sweep: for c in status mcp skills agents doctor sandbox init system-prompt version; do ./rust/target/debug/claw --output-format json </dev/null | jq -e '.status | IN("ok","warn","error")'; done

Notes

  • Error semantics unchanged.
  • No unrelated LSP/MCP code touched.

Constraint: ROADMAP #458 requires top-level status on successful skills and agents JSON outputs without changing error semantics.
Confidence: high
Scope-risk: narrow
Directive: Preserve existing error envelopes and avoid unrelated LSP/MCP changes.
Tested: cargo fmt; cargo test -p commands; cargo build -p rusty-claude-cli --bin claw; rebuilt JSON status sweep for status/mcp/skills/agents/doctor/sandbox/init/system-prompt/version.
Not-tested: full workspace cargo test.
@code-yeongyu
Copy link
Copy Markdown
Collaborator

Closing — this is a duplicate of #3100 which was just merged as 16604a11. The branch wasn't rebased after #3100 merged, so the diff still shows the pre-merge state (index b4358d20ab) and would reintroduce duplicate status keys already present in main. All the test assertions from this PR are already in main via #3100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants