Skip to content

Feature jm 10 update 3.4 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpmmartins wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Feature jm 10 update 3.4 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc678c7
#10 adds date format modifier
jpmmartins Mar 24, 2025
c8f78ff
#10 fix doi side block
jpmmartins Jan 7, 2026
984bc39
#10 replace url with doi
jpmmartins Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions InlineHtmlGalleySidebarBlockPlugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,24 +61,6 @@ class InlineHtmlGalleyDoiSidebarBlockPlugin extends InlineHtmlGalleySidebarBlock
function blockName() {
return "doi";
}

/**
* @copydoc BlockPlugin::getContents()
*/
function getContents($templateMgr, $request = null) {
if ($templateMgr && $request) {
$pubIdPlugins = $templateMgr->getTemplateVars('pubIdPlugins');
if ($pubIdPlugins) {
foreach ($pubIdPlugins as $pubIdPlugin) {
if ($pubIdPlugin->getPubIdType() == 'doi') {
return parent::getContents($templateMgr, $request);
}
}
}
}

return false;
}
}

class InlineHtmlGalleyCoverImageSidebarBlockPlugin extends InlineHtmlGalleySidebarBlockPlugin {
Expand Down
26 changes: 9 additions & 17 deletions templates/blockDoi.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,18 @@
*
*}
<div class="pkp_block block_inline_html_doi">
<span class="title">{translate key="plugins.pubIds.doi.readerDisplayName"}</span>
{* DOI (requires plugin) *}
{foreach from=$pubIdPlugins item=pubIdPlugin}
{if $pubIdPlugin->getPubIdType() != 'doi'}
{continue}
{/if}
{if $issue->getPublished()}
{assign var=pubId value=$article->getStoredPubId($pubIdPlugin->getPubIdType())}
{else}
{assign var=pubId value=$pubIdPlugin->getPubId($article)}{* Preview pubId *}
{/if}
{if $pubId}
{assign var="doiUrl" value=$pubIdPlugin->getResolvingURL($currentJournal->getId(), $pubId)|escape}
<span class="title">{translate key="doi.readerDisplayName"}</span>
{* DOI *}
{assign var=doiObject value=$article->getCurrentPublication()->getData('doiObject')}
{if $doiObject}
{assign var="doi" value=$doiObject->getData('doi')}
{assign var="doiUrl" value=$doiObject->getData('resolvingUrl')|escape}
<div class="list-group-item doi">
{capture assign=translatedDoi}{translate key="plugins.pubIds.doi.readerDisplayName"}{/capture}
{capture assign=translatedDoi}{translate key="doi.readerDisplayName"}{/capture}
<strong>{translate key="semicolon" label=$translatedDoi}</strong>
<a href="{$doiUrl}">
{$doiUrl}
{$doi}
</a>
</div>
{/if}
{/foreach}
{/if}
</div>
2 changes: 1 addition & 1 deletion templates/blockPublishedDate.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<div class="list-group-item date-published">
{capture assign=translatedDatePublished}{translate key="submissions.published"}{/capture}
<strong>{translate key="semicolon" label=$translatedDatePublished}</strong>
{$publication->getData('datePublished')|date_format}
{$publication->getData('datePublished')|date_format:$dateFormatShort}
</div>
{* If this is an updated version *}
{if $firstPublication->getID() !== $publication->getId()}
Expand Down