39 bug submit request button not working for request retrieval #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #39. There is another half of this fix in the euk branch of ukl-ansible-playbooks which is already in production.
Changes
The config for exploreuk in production was redirecting all php requests for findingaid to index.php. When the client-side application requested
public/date.php, it was redirecting topublic/index.php, thus responses would be treated as a request for the default page and return theindex.mustachecomponent. Dev did not have this problem because it uses a nginx different configuration to combine findingaid and exploreuk-web-app.The functionality that
date.phpprovided is, as far as I can tell, not needed at this time. There was a comment in/app/assets/js/requests.jsthat had this removal marked as a todo. There are a few fields being preserved, but the actual functionality is dead code and is trimmed here.commit history note: I was finished with a client-side rework when I realized much of this was dead code, so there is a commit with this rework and an immediate deletion.