Skip to content

Updated feasible_point to search over scan points #4552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothy-nunn merged 2 commits into from
Sep 9, 2026
Merged

Updated feasible_point to search over scan points #4552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b48734
Updated feasible_point to search over scan points
j-a-foster Aug 25, 2026
c18a291
Updated feasible_point to work for scan points other that 1
j-a-foster Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions process/core/io/in_dat/create.py
View file
Open in desktop
Comment thread
timothy-nunn marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -38,25 +38,20 @@ def feasible_point(filename, position: int):

if position == -1:
position = num_scans

position = max(1, position)

if position > num_scans:
position = num_scans
print(f"Only {num_scans} in mfile selecting last feasible_point")

check_point = 1

for value in mfile_data.data:
# Look for feasible scan points (with ifail = 1)
if "ifail" in value and "vmcon_error_flag_(ifail)" not in value:
if mfile_data.get(value, scan=check_point) == 1:
scan_point = check_point
if check_point == position:
break
check_point += 1
elif position not in range(1, num_scans + 1):
raise ValueError(
"Invalid value given. "
f"Select value in range 1-{num_scans} or -1 for last scan point."
)

if mfile_data.get("ifail", scan=position) == 1:
scan_point = position
else:
raise ValueError("No feasible point found")
raise ValueError(
f"Scan point {position} is not feasible. "
f"Please select a different scan point."
)

return scan_point


Expand Down
Loading