Skip to content

Perform power_at_ignition_point on a proxy stellarator data structure#4291

Open
timothy-nunn wants to merge 2 commits into
mainfrom
1841-follow-up-from-resolve-convert-stellaratorf90-to-python
Open

Perform power_at_ignition_point on a proxy stellarator data structure#4291
timothy-nunn wants to merge 2 commits into
mainfrom
1841-follow-up-from-resolve-convert-stellaratorf90-to-python

Conversation

@timothy-nunn
Copy link
Copy Markdown
Collaborator

@timothy-nunn timothy-nunn commented Jun 4, 2026

Removes the need for the stellarator power at ignition model to modify the data structure, run physics, extract results, reset the data structure, and then run physics to converge back to the old point. Instead, we make a copy of the data structure, mutate this instance of the data, run the models, extract the data of interest, and then discard the mutated structure.

@timothy-nunn timothy-nunn linked an issue Jun 4, 2026 that may be closed by this pull request
1 task
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 4, 2026

Codecov Report

❌ Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.65%. Comparing base (260e0e1) to head (aa81b27).

Files with missing lines Patch % Lines
process/models/stellarator/denisty_limits.py 12.50% 7 Missing ⚠️
process/models/stellarator/stellarator.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4291      +/-   ##
==========================================
+ Coverage   48.64%   48.65%   +0.01%     
==========================================
  Files         151      151              
  Lines       29283    29274       -9     
==========================================
  Hits        14244    14244              
+ Misses      15039    15030       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn marked this pull request as ready for review June 4, 2026 10:18
@timothy-nunn timothy-nunn requested a review from a team as a code owner June 4, 2026 10:18
@timothy-nunn timothy-nunn marked this pull request as draft June 4, 2026 10:19
@timothy-nunn timothy-nunn marked this pull request as ready for review June 4, 2026 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-up from "Resolve "convert stellarator.f90 to Python""

3 participants