-
Notifications
You must be signed in to change notification settings - Fork 18
♻️ Refactor CS coil #4262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chris-ashe
wants to merge
38
commits into
main
Choose a base branch
from
refactor_cs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
♻️ Refactor CS coil #4262
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
ca38065
Rename hoop_stress method to calculate_cs_hoop_stress and update refe…
chris-ashe 051ec2d
Enhance CS hoop stress calculation with additional parameters and upd…
chris-ashe 24e5029
Refactor CS hoop stress calculation to include additional parameters …
chris-ashe 388ba0c
Rename sig_hoop variable to stress_hoop_cs for clarity and update ref…
chris-ashe fa96be9
Update CSCoil docstring to clarify parameters and add reference for h…
chris-ashe 5e0b4bd
Rename stress_hoop_cs variable to stress_hoop_cs_inner for clarity an…
chris-ashe 75d5f2b
Add stress_hoop_cs_inner_profile variable and update initialization i…
chris-ashe ba6c689
Add a_cs_steel_poloidal variable and update initialization in PF coil…
chris-ashe 077750e
Refactor CSCoil to calculate a_cs_steel_poloidal directly and update …
chris-ashe 6e7facf
Update output to reference a_cs_steel_poloidal in PF coil module
chris-ashe 64f7032
Refactor variable names from awpoh to a_cs_cable_space across multipl…
chris-ashe a96ff23
Add inner and outer radius variables for central solenoid in PF coil …
chris-ashe c35cee4
Add radial inner and outer parameters for central solenoid in PF coil…
chris-ashe 2f0cdea
Add radial hoop stress profile plotting to CSCoil class and update pa…
chris-ashe 159ea2b
Refactor CSCoil class to add radial stress profile calculations and u…
chris-ashe e381a30
Refactor CSCoil class to rename and enhance magnetic field calculatio…
chris-ashe 431484e
Add peak field variable for central solenoid bore in PF coil module
chris-ashe e60228a
Add magnetic field variable for outer edge of central solenoid at mid…
chris-ashe e5ed3ea
Add operating temperature variable for central solenoid and update in…
chris-ashe 99d858d
Update operating temperature for central solenoid superconductor
chris-ashe 42bb565
Post rebase fixes
chris-ashe 7f3a2ef
Update unit test
chris-ashe b0db34f
Add CSGeometry dataclass
chris-ashe ebae313
Refactor CS stress plotting functions for clarity and consistency
chris-ashe e5661e7
Update docs
chris-ashe e822815
:sparkle: Add `a_cs_toroidal` to store the top down cross section
chris-ashe b9edd39
Update CS geometry docs
chris-ashe 8209fec
Add EU DEMO turn geometry calculations and update tests
chris-ashe ff90d0b
Refactor central solenoid variable descriptions for clarity and consi…
chris-ashe acd521f
Refactor output comments and streamline superconductor information in…
chris-ashe cc5c3e6
Refactor output formatting in PFCoil model for improved readability a…
chris-ashe 159dc46
Update integration test MFILE data to include new CS outputs and prev…
chris-ashe 8aebfc3
Post rebase fixes
chris-ashe 78d190f
Apply suggestions from code review
chris-ashe 63d299a
Update type hint for central solenoid radial stress calculation to su…
chris-ashe 60c96bc
Post rebase fixes
chris-ashe 8f121bf
Set Poisson's ratio for steel structure to a constant value of 0.3 in…
chris-ashe e2ab146
Test each field of CSGeometry in unit tests
timothy-nunn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting some errors for the equations below, are they displaying ok for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You normally need to just refresh the page and they load