Skip to content

Jolt: fix Compound shapes not initializing their _shape #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
twhlynch wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Jolt: fix Compound shapes not initializing their _shape #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Modules/Jolt/RNJoltShape.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ namespace RN

JoltCompoundShape::JoltCompoundShape()
{
_shape = new JPH::MutableCompoundShape();
_shape->AddRef();
}

JoltCompoundShape::JoltCompoundShape(Model *model, JoltMaterial *material, Vector3 scale, bool useTriangleMesh, bool wantsDoubleSided)
Expand All @@ -229,6 +231,9 @@ namespace RN

JoltCompoundShape::JoltCompoundShape(const Array *meshes, JoltMaterial *material, Vector3 scale, bool useTriangleMesh, bool wantsDoubleSided)
{
_shape = new JPH::MutableCompoundShape();
_shape->AddRef();

meshes->Enumerate<Mesh>([&](Mesh *mesh, size_t index, bool &stop) {
AddChild(mesh, material, Vector3(), Quaternion(), scale, useTriangleMesh, wantsDoubleSided);
});
Expand Down