Skip to content

feat(stovepipe): Store currently open issues - #916

Merged
prathshenoy merged 1 commit into
mainfrom
codex/stovepipe-open-build-issue-storage
Oct 22, 2026
Merged

prathshenoy merged 1 commit into
mainfrom
codex/stovepipe-open-build-issue-storage

Conversation

@prathshenoy

@prathshenoy prathshenoy commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Summary

What:

  • Add queue-scoped storage for currently open issues, retaining the build that opened each occurrence.
  • Make deletion safe to repeat without removing a later opening of the same issue.

Why:

  • Separate current issue state from immutable per-build observations and prepare for issue lifecycle history without enabling reconciliation yet.

Test Plan

  • Add unit tests.
  • Verify open, remove, reopen, and concurrent creation against MySQL.

Revert Plan

  • Revert this PR. No runtime writer is enabled; the additive table can remain unused without affecting validation.

Issue Links

Stack

  1. feat(stovepipe): Persist build issue observations #902
  2. feat(stovepipe): Add build analysis polling #907
  3. feat(stovepipe): Record incomplete build analysis #915
  4. feat(stovepipe): Wire build analysis pipeline #909
  5. feat(stovepipe): Store currently open issues #916

@prathshenoy
prathshenoy added this pull request to stack #920 October 22, 2026 13:25
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-open-build-issue-storage branch 2 times, most recently from 3251029 to 76978d4 Compare October 22, 2026 15:21
Base automatically changed from codex/stovepipe-buildanalysis-wiring to main October 22, 2026 15:57
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-open-build-issue-storage branch 2 times, most recently from e0e302a to 9001fa5 Compare October 22, 2026 19:32
@prathshenoy prathshenoy changed the title feat(stovepipe): Store currently open build issues feat(stovepipe): Store currently open issues Oct 22, 2026
@prathshenoy
prathshenoy force-pushed the codex/stovepipe-open-build-issue-storage branch from 9001fa5 to f2df069 Compare October 22, 2026 19:40
@prathshenoy
prathshenoy marked this pull request as ready for review October 22, 2026 21:13
@prathshenoy
prathshenoy enabled stacked auto-merge October 22, 2026 21:13
@prathshenoy
prathshenoy added this pull request to the merge queue Oct 22, 2026
Merged via the queue into main with commit 473ab2c Oct 22, 2026
36 checks passed
@prathshenoy
prathshenoy deleted the codex/stovepipe-open-build-issue-storage branch October 22, 2026 21:29
DivyanshGarg380 pushed a commit to DivyanshGarg380/submitqueue that referenced this pull request Oct 24, 2026
## Summary

**What**:

- Persist individual validation issue observations per build and queue,
with duplicate detection.

**Why**:

- Retain observed failures across polls and restarts without replacing
earlier observations or rewriting serialized collections.

## Test Plan

- [x] Add unit tests.
- [x] Verify persistence against a real MySQL database.

## Revert Plan

- Revert this PR. No runtime consumer is enabled; the additive table can
remain unused without affecting validation.

## Issue Links

- [CODEM-607](https://linear.app/uber/issue/CODEM-607/build-analysis)

## Stack

1. uber#902
1. uber#907
1. uber#915
1. uber#909
1. uber#916
DivyanshGarg380 pushed a commit to DivyanshGarg380/submitqueue that referenced this pull request Oct 24, 2026
## Summary

**What**:

- Add periodic issue detection and durable observation recording, with a
final pass after observing build completion.
- Stop polling validations that end without a recorded build result and
use normal queue retry handling for analysis failures.

**Why**:

- Accumulate validation failures before build completion and retry
partial persistence without duplicating observations.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. No runtime wiring or schema changes are introduced,
and existing build processing is unchanged.

## Issue Links

- [CODEM-607](https://linear.app/uber/issue/CODEM-607/build-analysis)

## Stack

1. uber#902
1. uber#907
1. uber#915
1. uber#909
1. uber#916
DivyanshGarg380 pushed a commit to DivyanshGarg380/submitqueue that referenced this pull request Oct 24, 2026
## Summary

**What**:

- Record one history event per build when analysis cannot complete,
without rerunning detection or changing validation results.
- Retry history recovery failures while acknowledging messages that
cannot identify a valid build and request.

**Why**:

- Make potentially incomplete failure information visible without
blocking validation or repeatedly querying the build provider.

## Test Plan

- [x] Add unit tests.

## Revert Plan

- Revert this PR. No runtime wiring or schema changes are introduced, so
existing validation behavior is unchanged.

## Issue Links

- [CODEM-607](https://linear.app/uber/issue/CODEM-607/build-analysis)

## Stack

1. uber#902
1. uber#907
1. uber#915
1. uber#909
1. uber#916
DivyanshGarg380 pushed a commit to DivyanshGarg380/submitqueue that referenced this pull request Oct 24, 2026
## Summary

**What**:

- Connect build analysis to build-start and completion notifications,
using a no-op detector in the reference service while keeping result
recording independent.
- Configure bounded analysis retries and connect dead-letter recovery
that records incomplete analysis without rerunning detection.

**Why**:

- Keep result recording independent of issue detection while allowing
deployments to provide real detection.

## Test Plan

- [x] Add unit tests.
- [x] Verify the reference service integration with its default
detector.

## Revert Plan

- Revert this PR. No schema changes need reversal, and existing
observations can remain stored without affecting prior build processing.

## Issue Links

- [CODEM-607](https://linear.app/uber/issue/CODEM-607/build-analysis)

## Stack

1. uber#902
1. uber#907
1. uber#915
1. uber#909
1. uber#916
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants