feat(stovepipe): wire the build controller into the server#408
Open
roychying wants to merge 2 commits into
Open
feat(stovepipe): wire the build controller into the server#408roychying wants to merge 2 commits into
roychying wants to merge 2 commits into
Conversation
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
July 20, 2026 23:22
mnoah1
approved these changes
Jul 21, 2026
behinddwalls
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Wires
build.NewControllerintoservice/stovepipe/server/main.go. Adds afakeBuildRunnerFactoryexample backend (mirrors the existingfakeSourceControlFactorypattern). Extracts controller registration intoregisterPrimaryControllers/registerDLQControllershelpers so each factory is constructed once and threaded through every consumer, rather than duplicated per controller as more stages land. Gives thebuildtopic a realSubscription(it was publish-only fromprocessuntil now).Test Plan
make build,make test- all clean.Issue