feat(example): per-queue extension wiring; retire buildrunner/noop

CLAUDE.md

@@ -116,6 +116,14 @@ Vendor-agnostic, pluggable interfaces with implementations in subdirectories:
 2. Implementations at `extension/{ext}/{impl}/`
 3. Factory interface for dependency injection and lifecycle management
 
+**Extensions hold contracts and implementations only — not factories or routing.**
+
+An `extension/{ext}` package contains the behavioral interface, its `Config`, the `Factory` *interface*, and impl constructors `New(...)` that return the interface. It must **not** contain `Factory` *implementations* (`NewFactory()` constructors or factory structs) or any queue-selection logic.
+
+Why: an impl package (e.g. `scorer/heuristic`) can't know the queue topology or the other impls, so a "which impl for which queue" decision doesn't belong there. Per-queue routing — and the small adapters that wrap a `New(...)` impl in the `Factory` interface — live in the wiring layer (e.g. `example/{domain}/{service}/server/main.go`), the one place that knows the full queue set. That's where you route on `Config.QueueName`.
+
+Rule of thumb: if you're about to add a `NewFactory()` or a `map[queue]impl` under `extension/`, it belongs in the wiring layer instead.
+
 **Design interfaces for the technology *space*, not the implementation in front of you.** The interface is a contract every backend will have to satisfy — SQL, key-value (DynamoDB, Bigtable), document, message queue, search, RPC, in-memory, mocks. If the contract assumes a capability that some plausible backend can't provide cheaply, you've baked the current impl's strengths into the API.
 
 Common over-constraints to avoid:

example/submitqueue/gateway/server/queues.yaml

@@ -7,3 +7,7 @@ queues:
   - name: test-queue
   - name: e2e-test-queue
   - name: e2e-cancel-queue
+  # Routes to an analyzer that always errors (conflictfake.FailAlways) so e2e can
+  # exercise the conflict-analysis error path. See newQueueRegistry in the
+  # orchestrator example server.
+  - name: e2e-conflict-error-queue

example/submitqueue/orchestrator/server/BUILD.bazel

@@ -22,16 +22,23 @@ go_library(
         "//submitqueue/core/consumer",
         "//submitqueue/entity",
         "//submitqueue/extension/buildrunner",
-        "//submitqueue/extension/buildrunner/noop",
+        "//submitqueue/extension/buildrunner/fake",
         "//submitqueue/extension/changeprovider",
+        "//submitqueue/extension/changeprovider/fake",
         "//submitqueue/extension/changeprovider/github",
         "//submitqueue/extension/conflict",
         "//submitqueue/extension/conflict/all",
+        "//submitqueue/extension/conflict/fake",
+        "//submitqueue/extension/conflict/none",
         "//submitqueue/extension/mergechecker",
+        "//submitqueue/extension/mergechecker/fake",
         "//submitqueue/extension/mergechecker/github",
         "//submitqueue/extension/pusher",
+        "//submitqueue/extension/pusher/fake",
         "//submitqueue/extension/pusher/git",
         "//submitqueue/extension/scorer",
+        "//submitqueue/extension/scorer/composite",
+        "//submitqueue/extension/scorer/fake",
         "//submitqueue/extension/scorer/heuristic",
         "//submitqueue/extension/storage",
         "//submitqueue/extension/storage/mysql",

submitqueue/orchestrator/controller/build/BUILD.bazel

@@ -28,8 +28,8 @@ go_test(
         "//submitqueue/core/consumer",
         "//submitqueue/entity",
         "//submitqueue/extension/buildrunner",
+        "//submitqueue/extension/buildrunner/fake",
         "//submitqueue/extension/buildrunner/mock",
-        "//submitqueue/extension/buildrunner/noop",
         "//submitqueue/extension/storage",
         "//submitqueue/extension/storage/mock",
         "@com_github_stretchr_testify//assert",

submitqueue/orchestrator/controller/build/build_test.go

@@ -28,8 +28,8 @@ import (
 	"github.com/uber/submitqueue/submitqueue/core/consumer"
 	"github.com/uber/submitqueue/submitqueue/entity"
 	"github.com/uber/submitqueue/submitqueue/extension/buildrunner"
+	buildfake "github.com/uber/submitqueue/submitqueue/extension/buildrunner/fake"
 	buildrunnermock "github.com/uber/submitqueue/submitqueue/extension/buildrunner/mock"
-	buildnoop "github.com/uber/submitqueue/submitqueue/extension/buildrunner/noop"
 	"github.com/uber/submitqueue/submitqueue/extension/storage"
 	storagemock "github.com/uber/submitqueue/submitqueue/extension/storage/mock"
 	"go.uber.org/mock/gomock"
@@ -74,7 +74,7 @@ func newMockStorage(ctrl *gomock.Controller, batch entity.Batch) *storagemock.Mo
 }
 
 // newTestController creates a controller with test dependencies. br is the
-// build runner to inject; pass buildnoop.New() for the pass-through default.
+// build runner to inject; pass buildfake.New() for the pass-through default.
 // staticBuildRunnerFactory is a test factory that returns a fixed BuildRunner
 // for any entityqueue.
 type staticBuildRunnerFactory struct{ r buildrunner.BuildRunner }
@@ -111,7 +111,7 @@ func TestNewController(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	batch := testBatch()
 	store := newMockStorage(ctrl, batch)
-	controller := newTestController(t, ctrl, store, buildnoop.New(), nil)
+	controller := newTestController(t, ctrl, store, buildfake.New(), nil)
 
 	require.NotNil(t, controller)
 	assert.Equal(t, consumer.TopicKeyBuild, controller.TopicKey())
@@ -124,7 +124,7 @@ func TestController_Process_Success(t *testing.T) {
 
 	batch := testBatch()
 	store := newMockStorage(ctrl, batch)
-	controller := newTestController(t, ctrl, store, buildnoop.New(), nil)
+	controller := newTestController(t, ctrl, store, buildfake.New(), nil)
 
 	msg := entityqueue.NewMessage(batch.ID, batchIDPayload(t, batch.ID), batch.Queue, nil)
 	delivery := queuemock.NewMockDelivery(ctrl)
@@ -315,7 +315,7 @@ func TestController_Process_StorageFailure(t *testing.T) {
 	store.EXPECT().GetRequestStore().Return(storagemock.NewMockRequestStore(ctrl)).AnyTimes()
 	store.EXPECT().GetBuildStore().Return(storagemock.NewMockBuildStore(ctrl)).AnyTimes()
 
-	controller := newTestController(t, ctrl, store, buildnoop.New(), nil)
+	controller := newTestController(t, ctrl, store, buildfake.New(), nil)
 
 	msg := entityqueue.NewMessage("test-queue/batch/1", batchIDPayload(t, "test-queue/batch/1"), "test-queue", nil)
 	delivery := queuemock.NewMockDelivery(ctrl)
@@ -332,7 +332,7 @@ func TestController_Process_PublishFailure(t *testing.T) {
 
 	batch := testBatch()
 	store := newMockStorage(ctrl, batch)
-	controller := newTestController(t, ctrl, store, buildnoop.New(), fmt.Errorf("publish failed"))
+	controller := newTestController(t, ctrl, store, buildfake.New(), fmt.Errorf("publish failed"))
 
 	msg := entityqueue.NewMessage(batch.ID, batchIDPayload(t, batch.ID), batch.Queue, nil)
 	delivery := queuemock.NewMockDelivery(ctrl)
@@ -347,7 +347,7 @@ func TestController_InterfaceImplementation(t *testing.T) {
 	ctrl := gomock.NewController(t)
 	batch := testBatch()
 	store := newMockStorage(ctrl, batch)
-	controller := newTestController(t, ctrl, store, buildnoop.New(), nil)
+	controller := newTestController(t, ctrl, store, buildfake.New(), nil)
 
 	var _ consumer.Controller = controller
 }