Restructure Stovepipe under gateway; add core/extension#174
Closed
mnoah1 wants to merge 2 commits into
Closed
Conversation
Move proto, generated gRPC Go, and controllers into stovepipe/gateway; add stovepipe/orchestrator, entity, and extension stubs; introduce core/extension for shared extensions. Update Makefile proto paths, Gazelle resolve, examples, and integration tests. Drop committed stovepipe.pb.yarpc.go (regenerate via make proto when YARPC is needed). SubmitQueue gateway/orchestrator unchanged.
behinddwalls
reviewed
Jun 2, 2026
|
|
||
| // Package extension holds extension interfaces and implementations shared | ||
| // across SubmitQueue, Stovepipe, and other repo-local services. | ||
| package extension |
Collaborator
There was a problem hiding this comment.
I think we have been adding README.md files in such places...do we want to add those or switch to doc.go files?
Contributor
Author
There was a problem hiding this comment.
I still have it in draft, will enqueue once ready
behinddwalls
reviewed
Jun 2, 2026
Collaborator
behinddwalls
left a comment
behinddwalls
left a comment
There was a problem hiding this comment.
Do we also want to break the test folders?
test/e2e/submitqueue/test_suite.go
test/e2e/stovepipe/test_suite.go
test/integration/submitqueue/gateway/test_suite.go
test/integration/submitqueue/orchestrator/test_suite.go
test/integration/submitqueue/extension/test_suite.go
Contributor
Author
|
Abandoning as duplicate of #181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stovepipe/gateway/(proto, generated gRPC Go, controllers) and update import paths, Bazel deps,Makefileproto/clean targets, and root Gazelle resolve.core/extension/,stovepipe/orchestrator/,stovepipe/entity/,stovepipe/extension/(doc-only packages + BUILD files) to match the intended multi-product layout; SubmitQueuegateway/andorchestrator/are unchanged.stovepipe.pb.yarpc.go; nothing referenced it. Regenerate withmake protowhen protoc + YARPC plugins are available if YARPC bindings are needed again.Test plan
make gazelle/make fmtbazel test //stovepipe/...