chore(deps): set grpc and rpc versions to be compatible with internal monorepo#171
Merged
Conversation
Revert google.golang.org/grpc from v1.67.3 to v1.68.1 -- the pre-security-bump (#146) known-good version -- and pin the transitive google.golang.org/genproto/googleapis/rpc to v0.0.0-20241230172942-26aa7a208def to match the internal monorepo. grpc v1.68.1 only transitively requires genproto/rpc ...20240903143218, so the explicit Dec-2024 pin holds cleanly under MVS. Update the dependabot ignore comment to v1.68.x (the ignore rule itself is unchanged and still blocks all grpc bumps). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR adjusts Go module dependencies to use a “known-good” gRPC version and to align the transitive genproto/googleapis/rpc module version with an internal monorepo baseline, along with a small Dependabot comment update.
Changes:
- Update
google.golang.org/grpcfromv1.67.3tov1.68.1. - Add/adjust an explicit indirect requirement on
google.golang.org/genproto/googleapis/rpcatv0.0.0-20241230172942-26aa7a208def. - Update
go.sumand tweak the Dependabot ignore comment for gRPC.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
go.mod |
Bumps gRPC to v1.68.1 and pins the indirect genproto/googleapis/rpc minimum version. |
go.sum |
Updates checksums to match the new gRPC and genproto/googleapis/rpc versions. |
.github/dependabot.yml |
Updates the inline comment describing the intentional gRPC ignore/pin behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
albertywu
changed the title
albertywu
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
behinddwalls
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previous PR forgot to downgrade the rpc version to be compatible with our internal monorepo.
This PR sets the grpc / rpc versions to be compatible with our internal monorepo. Using the versions that precede this dependabot PR, which introduced versions incompatible with our monorepo verions.
Since both versions here are <= monorepo versions, it avoids forcing a monorepo bump of these dependencies.
Test Plan
make test