chore(deps): pin grpc to v1.67.3 and stop dependabot from re-bumping it#170
Merged
Conversation
…ndabot Downgrade from v1.79.3 to v1.67.3. The earlier auto-bump to v1.79.3 came from a Dependabot security-update PR (#146); add .github/dependabot.yml with an ignore rule for google.golang.org/grpc so future security-advisory PRs for this dependency are suppressed and the pin sticks. open-pull-requests-limit: 0 keeps the prior behavior of no scheduled version-update PRs; only security updates run, and the ignore rule excludes grpc from those. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
albertywu
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
There was a problem hiding this comment.
Pull request overview
This PR pins google.golang.org/grpc back to v1.67.3 and adds Dependabot configuration intended to prevent automatic grpc re-bumps while preserving security update behavior for other dependencies.
Changes:
- Downgrades grpc in
go.mod. - Updates
go.sumto match the downgraded grpc dependency graph. - Adds
.github/dependabot.ymlwith gomod update settings and a grpc ignore rule.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
go.mod |
Pins grpc to v1.67.3. |
go.sum |
Removes checksums for transitive modules no longer required by grpc v1.67.3 and adds v1.67.3 checksums. |
.github/dependabot.yml |
Adds Dependabot gomod configuration and grpc ignore rule. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
behinddwalls
approved these changes
May 30, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google.golang.org/grpcfrom v1.79.3 back to v1.67.3 (go.mod/go.sum)..github/dependabot.ymlwith anignorerule forgoogle.golang.org/grpcso Dependabot stops opening bump PRs for it — including security-advisory PRs, which is how it got bumped to v1.79.3 last time in chore(deps): bump google.golang.org/grpc from 1.68.1 to 1.79.3 #146.open-pull-requests-limit: 0preserves the repo's current behavior of no scheduled version-update PRs; only security updates run, and grpc is now excluded from those.Why?
grpc is a pre-existing dependency in our uber internal bazel monorepo. When we tried bumping grpc version, it caused this transitive dependency to bump as well, which has unknown risk in our monorepo:
google.golang.org/genproto/googleapis/rpcTo be safe, pin the version of grpc here to match what is used in our internal monorepo.
See internal PR for more details: https://github.com/uber-code/go-code/pull/134384
Test plan
make test— all 35 unit tests passmake integration-test— all 8 integration tests passmake e2e-test— passesmake check-tidy/make check-gazelle/make lint-fmt— clean against committed state🤖 Generated with Claude Code