Add note about canonical order of UKI components#181
Merged
Conversation
keszybz
reviewed
Nov 14, 2025
behrmann
reviewed
Nov 14, 2025
bluca
reviewed
Nov 14, 2025
Collaborator
|
I don't think should be a comment. If we define a canonical order, then we should say so in the spec, and not in a comment in the spec. Hence please reword this, and make this regular text |
Contributor
Author
|
That was my original plan but @bluca said I should do a comment instead. Can y'all come to consensus before I move forward? I don't want to ping-pong back and forth |
Member
|
It's fine to say it in the spec too (I'd also keep the comment immediately above so that it's harder to accidentally miss) |
Collaborator
|
Any chance you can add a brief comment to the visible part of the spec as suggested? seems good to go otherwise |
Co-authored-by: Zbigniew Jędrzejewski-Szmek <zbyszek@amutable.com>
Member
|
I updated the patch to have both the comment and the visible text. |
brauner
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.