Skip to content

uki: describe .efifw section#131

Merged
keszybz merged 1 commit into
uapi-group:mainfrom
ani-sinha:main
Jun 11, 2026
Merged

uki: describe .efifw section#131
keszybz merged 1 commit into
uapi-group:mainfrom
ani-sinha:main

Conversation

@ani-sinha

@ani-sinha ani-sinha commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Add description for the firmware section (.efifw) in the specs.

See also systemd/systemd#35091

@Foxboron

Copy link
Copy Markdown
Member

My general feeling is that this is too generic? Is there no expectations to the embedded blob? Is this all an implementation detail?

And if it only an implementation detail, how often would this actually be used by others beyond the usecase in the systemd PR?

@keszybz

keszybz commented Nov 13, 2024

Copy link
Copy Markdown
Member

I think being generic here is fine. What matters is that the firmware is in some format acceptable to the hardware. We can't really say much about it this point. If this becomes established, we can add additional details later.

@ani-sinha ani-sinha changed the title uki: describe .fmw section uki: describe .efifwauto section Nov 24, 2024
@ani-sinha ani-sinha changed the title uki: describe .efifwauto section uki: describe .fwauto section Dec 13, 2024
Comment thread specs/unified_kernel_image.md Outdated
@ani-sinha ani-sinha changed the title uki: describe .fwauto section uki: describe .efifw section Jan 22, 2025
@poettering

Copy link
Copy Markdown
Collaborator

Sorry for dropping the ball on this. Could you please rebase this? We really should get this landed.

Please follow the wording of the .dtbauto stuff regarding the matching.

@keszybz

keszybz commented Oct 27, 2025

Copy link
Copy Markdown
Member

@ani-sinha ping

@katexochen

Copy link
Copy Markdown

I've rebased and updated this in #216, PTAL

@ani-sinha

Copy link
Copy Markdown
Contributor Author

Sorry for dropping the ball on this. Could you please rebase this? We really should get this landed.

Please follow the wording of the .dtbauto stuff regarding the matching.

Sorry I too forgot about this. Let me try and get to this in the next few days.

@ani-sinha

Copy link
Copy Markdown
Contributor Author

Sorry for dropping the ball on this. Could you please rebase this? We really should get this landed.

Please follow the wording of the .dtbauto stuff regarding the matching.

@poettering So I was trying to update the doc and looked at the code. I see that chid_match() is only called for DEVICE_TYPE_DEVICETREE types of device entries and not for DEVICE_TYPE_UEFI_FW types of entries. So it won't match against the hardware chid. I think there is a gap in the implementation.

Add description for the firmware section (`.efifw`) in the specs.
@keszybz

keszybz commented Jun 11, 2026

Copy link
Copy Markdown
Member

We now have two versions of this PR. Since this one was earlier, I'll merge it. If subsequent changes should be done, let's do that later.

@keszybz keszybz merged commit 0bc7fb8 into uapi-group:main Jun 11, 2026
1 check passed
@ani-sinha

Copy link
Copy Markdown
Contributor Author

Sorry for dropping the ball on this. Could you please rebase this? We really should get this landed.
Please follow the wording of the .dtbauto stuff regarding the matching.

@poettering So I was trying to update the doc and looked at the code. I see that chid_match() is only called for DEVICE_TYPE_DEVICETREE types of device entries and not for DEVICE_TYPE_UEFI_FW types of entries. So it won't match against the hardware chid. I think there is a gap in the implementation.

I have started a PR here: systemd/systemd#42570 Still in draft, I want to see if I introduced any regressions or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants