Add more stacked tilde variants - #181
Open
MDLC01 wants to merge 1 commit into
Open
Conversation
MDLC01
added
breaking
Collaborator
Author
|
This PR is missing three approvals to be merged. If you disagree with a specific change, feel free to express your concern here or on Discord. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a few symbols composed of stacked tildes and horizontal lines. I explain the reasoning for each change below.
tilde.doublemakes sense in my opinion as a non-semantic variant ofapprox. I have chosen to only include the.notvariant but I am open to including.eq,.equiv, and.hatas well. I am also open to excludingtilde.doublefrom this PR if we are unable to reach a consensus.The rename from
minus.tildetoeq.tildeis consistent with the existingtilde.eq, as well as the Unicode character being a Relation, not a Binary, even though its name uses "MINUS" instead of "EQUAL". Same fortilde.eq.tilde.equiv.tildeis consistent with the existingtilde.equiv.approx.equivis consistent with other uses of.equiv, such as intilde.equiv.