Add union-branch ordering coverage on a schema-qualified table - #904
Merged
Merged
Conversation
phdoerfler
force-pushed
the
topic/union-order-coverage
branch
from
August 20, 2026 01:25
cb50dc8 to
94343f3
Compare
Runs on Postgres, skunk, MSSQL and Oracle. A schema is a user in Oracle, so the fixture there needs a second user.
phdoerfler
force-pushed
the
topic/union-order-coverage
branch
from
August 20, 2026 10:44
94343f3 to
3264c3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a shared
SqlUnionOrderSuitethat tests a union withorderandlimit, run on Postgres, skunk, MSSQL and Oracle against a schema-qualified table (qualified.union_order_entities).#871 changed how qualified table names are folded in MSSQL union-branch encapsulation, but its tests (
SqlQualifiedNamesSuite) only run on Postgres and skunk, so those MSSQL paths have no test today. The existingSqlUnionSuitedoes not cover order or limit on any backend.The rows are inserted out of alphabetical order on purpose (id 1 Charlie, 2 Alpha, 3 Bravo, 4 Delta), so a query that returns the first two in insert order cannot pass the check by chance.
A schema is a user in Oracle, so the fixture there needs a second user.
01_create_user.sqlcreates it and grants TEST the rights to populate it, includingCREATE ANY INDEXfor the primary key index.Test only, no library changes.