Repository navigation
Rechecks the callouts on BETA 1034, ties every BETA <n> callout to a check, and adds error-code search entries, FAQ entries and Help add-in changes. - #259
Merged
Conversation
…VB6's own OCXs (SysWOW64, design-time licences from .srg files) and whether packages are reviewed; bug reports (BETA number, minimal project, trace log), the Help add-in, TypeLibrary TLB and the Object Browser added; Build Type, Startup Object and TWINBASIC_BUILD_TYPE list TypeLibrary TLB; RunAfterBuild ignored and RunBeforeStartupObject run in a package
…buted sections still to come); 14 filed defects fixed in 1034 retired with their callouts and stated as correct behaviour with run samples (ReDim inverted bounds and empty range, CDate, Val suffix, Abs, Round(Null), String(n, Null), Sin/Cos from 2^63, DateAdd month end, TextBox MaxLength, Err.Raise HelpContext:=, LLVM rounding and ByVal-to-ByRef, WebView2 header Clone); RunAfterBuild only on a parameterless Sub (TB5155); LSet/RSet Variant and trig partly fixed; error data at beta 1034; LLVM claims probe test/llvm with Double overflow and For-Step WARNINGs corrected
…A 1034, and TBMANLIB 1.0.0.29 still fails in 64-bit only (same TB5001s): their callouts, the Experimental entries and the WIP notes name BETA 1034
… and relabelled: code-editor asserts that ( on a selected completion gives Twice(() (Tab the control), packages that Import from file leaves its copy under Packages after Cancel with the project unchanged; lane headers name BETA 1034
…1005; the ReDim fix makes six GdiPlus, TBMANLIB and ConsoleComponents cases and two printed messages (cAes, cXml) error 9 Subscript out of range; xCalendar's text colours and its four DateAdd methods work on 1034 with the package unchanged, the colour defect and the DateAdd WARNING removed and the colours stated as prose with their cases; Authoring's label example and WIP's add-in lane count (18) brought up to date
… marked on the section that explains each (index, with index_also for strong second pages), so a search for the code lands there; Attributes says which errors a misplaced attribute gives (TB5155, TB5182) and names TB5114 for a second RunAfterBuild
…orking on BETA 1034: listed in Contributed.md, its chapter in the book after VBComDlg's, out of Experimental.md and left_out
…B5182, with their messages on BETA 1034, as their search-index entry; BUGS entry tb5079-datatype-message-nested (a compile reproducer: since 1034 TB5079 for an unknown type nests its message in the one for a name) and its NOTE; WIP.Authoring states the TB code index rule
…arch bar (objListSearchBar, objListSearchEntry, a close button), as the Project Explorer and the Toolbox open it, its entry without a type attribute so the dialog's input rule leaves it alone; a missed search rings the entry in red; the help lane asserts the bar's computed style against the IDE's classes and that the close button closes it
… after a search for ctrl, shot Help_Find in shoot_docs' help setup (the text area keeps the focus so the match shows selected; the clip ends after twelve whole lines); one picture for both themes, the light pass having the dark one's pixels
…mes what checks it in <!-- test: ... -->, one grammar with the contributed sections' (scripts/lib/test-markers.mjs), on 246 callouts; gate check_callout_evidence.mjs in test.bat and CI; recheck_callouts.mjs runs the evidence on a new build, relabels what holds and lists the rest; check_examples gains probe fences (a sample the reader never sees) and arch=win32,win64 runs; probes for Compiler-Warnings' TB0018/19/21 NOTEs and the FAQ's msvbvm60 redirects
…ed in a dry run); checked end to end on BETA 1034 with 15 callouts and VBA.HiddenModule.yml aged to 1033, all relabelled back byte for byte
…its samples are not built and examples.bat prints no note for it
…Bad DLL definition; captureRun reads the kept clears on every poll of the build and ends at an open error panel, tbrun names the error (exit 5); BUGS entry declare-dll-stack-not-checked (a DLL Declare with the wrong convention or parameters raises nothing and crashes at the caller's return, where a static library's function or a Delegate raises -353703419 and VB6's IDE 49), WARNING BETA 1034 on Declare and API-Declarations, the static-library error on Static-Linking
… zero stored in a Single raises nothing, VB6 and 64-bit VBA raise 11 or 6; in the WARNING shared with #2476 on Divide, Single and Operators) and let-object-result-stored (a function's object result assigned to a Variant without Set is stored where VB6 raises 450 or 438; WARNING and a paragraph on Let); 64-bit VBA prints inf and -0 as a 64-bit build does, so infinity-text-64-bit is withdrawn, the -0 WARNINGs on CStr, Str and Format become NOTEs, Double states both per build with probes double-text-win32 and double-text-win64, NOTE on Round, rule in WIP.md
…s name their reproducers or samples; a compile case can name a row of a package's own source, so ArrayListLib, WinReg (compile/ alone) and TBMANLIB's win64 build check their does-not-compile callouts through package_tests
…runs exe/ cases in a built exe, with a server.mjs for them (GdiPlus start-up, cHttpClient's certificates); TimeZoneStandIn gives LocaleCollector's defect the same verdict all year; hidden samples check ListView TextBackground (templates wnc-form) and PropertyPage's semicolon (activex-control); test/static-linking and static <mode> markers check Static Linking's NOTE; makeBatches keeps each [RunAfterBuild] sample in a project of its own
…enario 11e, on a desktop from tbbroker; the scenario ends the COM-started explorer.exe, which outlives the exe, only if it started after the call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BETA <n>callouts name what checks them in<!-- test: ... -->. A new gate,check_callout_evidence.mjs, runs intest.batand CI.recheck_callouts.mjsruns the evidence on a new build and relabels what holds.check_examplesgainsprobefences andarch=win32,win64.test: nonereplaced: 20 callouts get a check, from package cases that name a row of a package's own source,exe/cases thatpackage_testsruns in a built exe, hidden samples andtest/static-linking.OpenFile's NOTE is checked by probe scenario 11e.RunAfterBuildandRunBeforeStartupObjectin a package.Help_Findpicture; the help lane asserts the bar's style and its close button.declare-dll-stack-not-checked(a DLLDeclarewith the wrong convention raises nothing and crashes at the caller's return),single-division-by-zero-no-error,let-object-result-storedandtb5079-datatype-message-nested, each with a callout on its pages. 64-bit VBA printsinfand-0as a 64-bit build does, soinfinity-text-64-bitis withdrawn and the-0WARNINGs on CStr, Str and Format become NOTEs.captureRunends at an open error panel, andtbrunnames the error and exits 5.