Use CARGO_MANIFEST_DIR from buildscript run time#2258
Open
dtolnay wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The libsql-ffi build script is assuming things about Cargo's implementation of build scripts which are not guaranteed by Cargo. In particular, the build script API does not make a guarantee that the following 3 directory paths would necessarily be identical:
It only guarantees that $CARGO_MANIFEST_DIR will be suitably set during each of the 3 steps. But it could be 3 different values.
The build script in libsql-ffi is taking a path from step 1 and trying to resolve its contents during step 2. That is not going to work in general, for example in an sccache-like remote execution scenario.