[pull] master from ruby:master - #1363
Merged
Merged
Conversation
ensure_origin read the m_tbl before the first write created the box-local classext, so the origin ICLASS captured the prime m_tbl while the subclass ICLASSes referred the box-local copy made by the CoW. rb_prepend_module then missed the shared m_tbl check and inserted the prepended module after the target module instead of before it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
With RUBY_BOX=1, firing an autoload invoked Ruby::Box#require on the registered box, bypassing any Kernel#require decoration (RubyGems, Zeitwerk, ...) prepended in that box. Zeitwerk's implicit namespaces rely on the decorated require, so a plain Rails app failed with LoadError on the first request. Call require on the box's top self in a frame running in that box instead, which dispatches the decorated method and still loads the feature into the box that registered the autoload.
RDoc 8 depends on rbs, and that dependency stays unresolved when several rbs versions are installed. It is then resolved on the first require of rbs, which happens inside Gem::RDoc#setup, after Gem::TestCase#setup has pointed GEM_HOME at an empty temporary directory, so it raises LoadError. ruby/rubygems@e794ab7e5f Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )