[pull] master from php:master - #1233
Merged
Merged
Conversation
Reverted in favor of a more complete fix.
* PHP-8.4: Revert the mysqlnd wireprotocol length-encoded bounds checks
* PHP-8.5: Revert the mysqlnd wireprotocol length-encoded bounds checks
…se (#23403) The stub declares array|false|null, but null is unreachable. The function has two exits: RETURN_FALSE for an unknown filter id, and the array handler, which establishes an array on both of its branches before doing anything else. Its remaining exits throw. The sibling filter_input_array() is declared identically and does return null, deliberately, because its source superglobal may not exist. That case has no equivalent here, where the source is a required array parameter. null remains an ordinary element value in the returned array, which is likely where the wider union came from; that is the value type, not the return type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )