Repository navigation
fix: declare the storage permission the extension background worker needs - #26
Merged
Merged
Conversation
…eeds ## Summary Fix: background notifications never scheduled in v0.4.0. Chrome reported `Failed to handle cancel-end: TypeError: Cannot read properties of undefined (reading 'session')` from `background.js`. The worker keeps the pending notification text in `chrome.storage.session`, which requires the `storage` permission; without it `chrome.storage` is undefined, so `schedule-end` and `cancel-end` both threw and no end-of-session alarm was ever set. The manifest now declares `storage` (no install warning). The worker's other APIs are covered: `alarms` and `notifications` are declared; `tabs.create/update`, `windows.update` and `runtime.getContexts` need no permission. ## Testing - Lint, typecheck, unit tests and build pass. - Built manifest lists `notifications`, `alarms`, `storage`. - Not run here: a real Chrome with the unpacked extension (this machine's Chrome ignores command-line extension loading); the earlier stub tests only covered the page side, which is how this slipped through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix: background notifications never scheduled in v0.4.0.
Chrome reported
Failed to handle cancel-end: TypeError: Cannot read properties of undefined (reading 'session')frombackground.js. The worker keeps the pending notification text inchrome.storage.session, which requires thestoragepermission; without itchrome.storageis undefined, soschedule-endandcancel-endboth threw and no end-of-session alarm was ever set. The manifest now declaresstorage(no install warning). The worker's other APIs are covered:alarmsandnotificationsare declared;tabs.create/update,windows.updateandruntime.getContextsneed no permission.Testing
notifications,alarms,storage.