Repository navigation
fix: focus the right field when a form, popover or menu opens - #25
Merged
Merged
Conversation
## Summary Whatever opens now puts keyboard focus where you'd type next. | Opens | Before | Now | | --- | --- | --- | | Edit Display Name (Alt+Shift+N / Welcome menu) | focus stayed on the page | name field focused, prefilled with the current name and selected | | Habit → Edit | stayed on the page | name field focused | | Goal → comments | stayed on the page | comment field focused | | Focus summary → edit session | stayed on the page | title field focused | | Add Tag popover (Alt+Shift+T / click) | stayed on the page | "Create new tag" focused; Esc closes | | Menu (Alt+M / click) | stayed on the button | first item focused; Esc closes and returns focus to the button | Already correct and unchanged: Alt+G (goal), Alt+N on To-Dos/Goals/Habits/Tags/Boost, to-do inline edits, habit notes, new tags, dialogs and panels. ## Testing - Lint, typecheck, unit tests and build pass. - In the browser: Alt+Shift+N → name field focused with "Alex" selected, Esc closes; Alt+Shift+T → "Create new tag" focused, Esc closes; Alt+M → first menu item focused, Esc closes; Alt+G → goal field focused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Whatever opens now puts keyboard focus where you'd type next.
Already correct and unchanged: Alt+G (goal), Alt+N on To-Dos/Goals/Habits/Tags/Boost, to-do inline edits, habit notes, new tags, dialogs and panels.
Testing