Skip to content

Use packaged check-shorts directly - #4150

Draft
Abse2001 wants to merge 3 commits into
mainfrom
agent/load-latest-check-shorts-at-runtime
Draft

Use packaged check-shorts directly#4150
Abse2001 wants to merge 3 commits into
mainfrom
agent/load-latest-check-shorts-at-runtime

Conversation

@Abse2001

@Abse2001 Abse2001 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove runtime dynamic loading of @tscircuit/check-shorts
  • statically import the checker functions used by tsci check shorts
  • update the packaged checker from 0.0.12 to 0.0.19
  • refresh the checker artifact snapshots for 0.0.19
  • compare PNG snapshots by decoded pixels so compression differences do not make CI platform-dependent

Review addressed

The requested dynamic-loading implementation has been removed entirely. The CLI no longer fetches package metadata, downloads or installs a tarball, maintains a runtime cache, imports a file URL, or falls back between online and packaged modules. It now uses the packaged dependency directly.

Validation

  • bun test tests/cli/check — 16 passed
  • bun test tests/cli/check/check-shorts.test.ts — 3 passed
  • bunx tsc --noEmit
  • bun run format:check
  • bun run build
  • git diff --check

@Abse2001
Abse2001 requested a review from seveibar August 10, 2026 11:21

@seveibar seveibar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy, just remove the dynamic loading altogether

@Abse2001 Abse2001 changed the title Load latest check-shorts at runtime Use packaged check-shorts directly Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants