Report check-shorts progress - #4139
Draft
seveibar wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
tsci check shortscan spend significant time rendering/routing a source circuit and rasterizing connectivity groups. With no intermediate output, the command looks like it has hung.High-level phase messages work with the currently packaged fallback checker. Granular rasterization events use the optional progress API introduced by tscircuit/check-shorts#40.
Dependency sequencing
Merge and release tscircuit/check-shorts#40 so the CLI's dynamic
latestimport receives granular checker events. The CLI remains backward-compatible when the loaded checker does not emit progress.Validation
bunx tsc --noEmitbun test tests/cli/check— 18 tests passedbun test tests/cli/check/check-shorts.test.ts— 5 tests passedbun run format:checkbun run build