fix: keep post drafts unscheduled by default - #209
Open
drbelt27 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the post creation and update scheduling behavior so drafts remain genuinely unscheduled when no schedule is provided.
Previously, creating a post without
scheduled_atcould silently assign a default schedule of today at 09:00 UTC. That behavior is risky for API/MCP clients because omitting a schedule should mean “create a draft”, not “schedule this content”.What Changed
CreatePostso missing or explicitnullscheduled_atresolves tonull.dateparameter behavior: whendateis explicitly provided, it still maps to 09:00 UTC for backwards compatibility.create-post-toolschema/description to document that omitted or nullscheduled_atcreates an unscheduled draft.update-post-toolvalidation sostatus=scheduledrequires an explicitscheduled_at.scheduled_atnull.scheduled_atstill publishes immediately and internally recordsscheduled_at = now().Why
Draft creation and scheduling are different user intents. API and MCP clients should be able to create draft posts without accidentally placing them on the calendar.
This makes scheduling explicit and fail-safe:
scheduled_at = nullValidation
Targeted validation on this branch:
./vendor/bin/pest tests/Unit/Actions/Post/CreatePostTest.php tests/Feature/Mcp/PostToolTest.php tests/Feature/Api/PostApiTest.php tests/Feature/PostControllerTest.php tests/Feature/PostTemplateControllerTest.php146 passed,512 assertionsThe same fix was also validated in the combined fork branch with the full suite:
./vendor/bin/pest:2664 passed,3 skipped,20372 assertions./vendor/bin/pint --teston touched files: passedgit diff --check: passed