Skip to content

Remove OS Thread from Atomics Wait Async#989

Merged
aapoalas merged 16 commits into
trynova:mainfrom
komyg:fix/remove-thread-from-wait-async
Jun 13, 2026
Merged

Remove OS Thread from Atomics Wait Async#989
aapoalas merged 16 commits into
trynova:mainfrom
komyg:fix/remove-thread-from-wait-async

Conversation

@komyg

@komyg komyg commented May 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@komyg komyg changed the title Fix/remove thread from wait async Remove OS Thread from Atomics Wait Async May 7, 2026
aapoalas
aapoalas requested changes Jun 7, 2026
View reviewed changes

@aapoalas aapoalas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me, but I had a few nitpicks regarding the inline comments that I'd like to fix before merging :)

Comment thread nova_vm/src/ecmascript/builtins/structured_data/atomics_object.rs Outdated
Comment thread nova_vm/src/ecmascript/builtins/structured_data/atomics_object.rs Outdated
Comment thread nova_vm/src/ecmascript/builtins/structured_data/atomics_object.rs Outdated
Comment thread nova_vm/src/ecmascript/builtins/structured_data/atomics_object.rs Outdated
@komyg komyg force-pushed the fix/remove-thread-from-wait-async branch from ffa98bd to 3f07edc Compare June 8, 2026 20:03
@komyg komyg requested a review from aapoalas June 10, 2026 00:00
@komyg

komyg commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

Hey @aapoalas, I've addressed your comments. Can you review again, please?

aapoalas
aapoalas requested changes Jun 11, 2026
View reviewed changes

@aapoalas aapoalas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disagree about the safe helper method, but otherwise this looks good to :)

@komyg komyg requested a review from aapoalas June 12, 2026 00:59
@komyg

komyg commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

I disagree about the safe helper method, but otherwise this looks good to :)

Thanks @aapoalas ! I've added the helper function you requested. Could you review again, please?

@aapoalas

aapoalas commented Jun 12, 2026

Copy link
Copy Markdown
Member

Something in lint is failing :(

@aapoalas

aapoalas commented Jun 12, 2026

Copy link
Copy Markdown
Member

Oh shit, dylint... Hmm

@komyg

komyg commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Hey @aapoalas, I had to update the Rust toolchain to make the Dylint work.

All steps are passing now. Could you review again, please?

eliassjogreen
eliassjogreen suggested changes Jun 12, 2026
View reviewed changes
Comment thread nova_vm/src/ecmascript/builtins/structured_data/atomics_object.rs Outdated
Comment thread nova_vm/src/ecmascript/builtins/structured_data/atomics_object.rs Outdated
aapoalas
aapoalas previously approved these changes Jun 13, 2026
View reviewed changes

@aapoalas aapoalas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: I'll fix the dylints, push to this PR, and merge once tests show all-green. Thanks for upgrading dylint <3 That's always something I'm afraid of doing :D

@aapoalas aapoalas merged commit 4eea7c6 into trynova:main Jun 13, 2026
8 checks passed
@komyg komyg deleted the fix/remove-thread-from-wait-async branch June 14, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aapoalas aapoalas aapoalas left review comments

+1 more reviewer

@eliassjogreen eliassjogreen eliassjogreen requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@komyg @aapoalas @eliassjogreen