fix(bake): confirm the box exists before sanitizing it - #271
Merged
Merged
Conversation
Sanitizing removes the operator's own SSH key — deliberately, since a key left in the image would grant its holder root on every clone. The provider lookup happened afterwards, so a target Hetzner could not match left a box that was already cleaned, no longer reachable, and never snapshotted. One wrong flag reaches it: `--server-id` takes the *provider's* server id, and Stacker's own server id is a different number entirely. Passing 702 sanitized a build box and then failed with "server not found", costing a redeploy and a 5 GB model pull. `resolve_snapshot_target` exposes the lookup the snapshot call already performed internally, and bake now runs it first — before the box is touched — reporting the resolved id so an operator can see which machine is about to be captured. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Copilot is generating a summary...]