Skip to content

feat(compose): parameterize env vars to prevent secret leakage in bak… - #259

Merged
vsilent merged 2 commits into
devfrom
feature/agent-sweep
Sep 19, 2026
Merged

vsilent merged 2 commits into
devfrom
feature/agent-sweep

Conversation

@vsilent

@vsilent vsilent commented Sep 19, 2026

Copy link
Copy Markdown
Collaborator

…ed snapshots

  • Add parameterize_compose_env_vars() to replace literal env values with ${VAR} references in generated compose files
  • Integrate into deploy pipeline so compose never contains author secrets
  • Docker Compose resolves ${VAR} from co-located .env at runtime
  • Add 3 unit tests for parameterization behavior

This fixes the security issue where every buyer of a marketplace template received the author's literal secrets in the baked compose file.

…ed snapshots

- Add parameterize_compose_env_vars() to replace literal env values with
  ${VAR} references in generated compose files
- Integrate into deploy pipeline so compose never contains author secrets
- Docker Compose resolves ${VAR} from co-located .env at runtime
- Add 3 unit tests for parameterization behavior

This fixes the security issue where every buyer of a marketplace template
received the author's literal secrets in the baked compose file.
@gitguardian

gitguardian Bot commented Sep 19, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
37449299 Triggered Generic High Entropy Secret 7b6c5e6 src/cli/generator/compose.rs View secret
37449298 Triggered Generic Password 7b6c5e6 src/cli/generator/compose.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@vsilent
vsilent merged commit 4b1e286 into dev Sep 19, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants