fix: bump courier-go SDK to v4.8.0 and fix explorer test#53
Open
mikemilla wants to merge 3 commits intorelease-please--branches--main--changes--nextfrom
Open
fix: bump courier-go SDK to v4.8.0 and fix explorer test#53mikemilla wants to merge 3 commits intorelease-please--branches--main--changes--nextfrom
mikemilla wants to merge 3 commits intorelease-please--branches--main--changes--nextfrom
Conversation
The release PR (3.3.0) introduced notification commands (create, retrieve, archive, publish, replace, list-versions) that reference SDK methods only available in courier-go v4.8.0. Upgrade the dependency from v4.7.0 to v4.8.0 so the build compiles. Also fix explorer_test.go: remove duplicate require import and extract orphaned marshalItemsToJSONArray assertions into their own test with a proper hasRawJSON test double. Made-with: Cursor
stainless-app
bot
force-pushed
the
release-please--branches--main--changes--next
branch
3 times, most recently
from
a1b1e72 to
290494a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
courier-goSDK from v4.7.0 to v4.8.0 to resolve 10 compilation errors inpkg/cmd/notification.go. The release PR (3.3.0) introduced notification commands (create,retrieve,archive,publish,replace,list-versions) that call SDK methods (New,Get,Archive,ListVersions,Publish,Replace) and reference param types (NotificationNewParams,NotificationGetParams, etc.) only available in v4.8.0.internal/jsonview/explorer_test.go: removes duplicaterequireimport and extracts orphanedmarshalItemsToJSONArrayassertions into a properly scopedTestMarshalItemsToJSONArray_WithHasRawJSONtest with arawJSONItemtest double.Test plan
go build ./...passesgo test ./...passes (all packages green)Made with Cursor