fix(background-checks): drop HEIC/HEIF from manual upload accept list#3235
Merged
Conversation
PR #3233 widened the background-check attach form to accept images, but included image/heic + image/heif. The API (validateFileContent in apps/api/src/utils/file-type-validation.ts) only validates PNG/JPEG/WEBP/PDF, so a HEIC/HEIF upload would be rejected server-side — and most browsers can't display HEIC, so it would store unviewable evidence even if accepted. Align the form's accepted types (and helper/error copy) with what the API actually takes: PDF, PNG, JPEG, WEBP. PDFs and the other image formats are unaffected. Note: candidates' own ID uploads already handle HEIC by converting it to JPEG in the browser (apps/web normalizeIdImage). This admin attach form does no such conversion, so offering HEIC here was misleading. If HEIC support is wanted on this form later, the right fix is client-side conversion, not raw HEIC at the API. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 3.87.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #3233. That PR correctly widened the background-check attach form to accept images (it previously rejected images the API already accepted), but it also added
image/heic+image/heif— which the API doesn't take.validateFileContent(apps/api/src/utils/file-type-validation.ts) validates by magic bytes and only accepts PNG / JPEG / WEBP / PDF. So a HEIC/HEIF upload via this form would be rejected server-side, and even if stored, most browsers (Chrome/Firefox) can't display HEIC — i.e. unviewable evidence. So the form was offering a format that can't actually work here.Change
Align the form's accepted types + helper/error copy with what the API actually accepts: PDF, PNG, JPEG, WEBP. PDF and the other image formats are unaffected.
Note on HEIC
Candidates' own ID uploads already support HEIC by converting it to JPEG in the browser (
apps/webnormalizeIdImage.ts) before anything reaches AWS. This admin attach form does no such conversion, so listing HEIC here was misleading. If HEIC support is wanted on this form later, the correct fix is client-side conversion (mirror the candidate flow), not accepting raw HEIC at the API.Tests
BackgroundCheckAttachForm.test.tsxupdated — the accept-attribute test now asserts WEBP is offered and HEIC is not. 4/4 pass.Related: CS-570, #3233.
🤖 Generated with Claude Code
Summary by cubic
Remove
image/heicandimage/heiffrom the background-check attach form to match API validation and avoid uploads that fail or can’t be viewed. Aligns accepted types, helper/error copy, and tests to support only PDF, PNG, JPEG, and WEBP, satisfying CS-570 and correcting the follow-up from #3233.Written for commit 6cbd40f. Summary will update on new commits.