[comp] Production Deploy by github-actions[bot] · Pull Request #2406 · trycompai/comp

github-actions · 2026-03-31T14:12:45Z

This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.

[dev] [Marfuen] mariano/eng-198-error-trying-to-run-cloud-tests

Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>

cursor · 2026-03-31T14:12:52Z

PR Summary

Medium Risk
Moderate risk because it removes Ramp as a built-in employee sync provider (API endpoints, scheduler, UI, and manifest/registry wiring) and adjusts who can set finding statuses, which could impact customer workflows if Ramp is still in use or admin role detection is wrong.

Overview
Removes Ramp as a built-in employee sync provider. Deletes the Ramp sync endpoints/services (including role-mapping discovery/save), drops Ramp from the sync scheduler and integration registry, and strips Ramp from the People UI (provider selection + role mapping tab/sheet) and integration catalog.

Tightens a few related UX/behavior edges. The API now clears employeeSyncProvider if it’s still set to ramp, sync result details rename rampStatus to a generic providerStatus, and the documents findings UI now derives isPlatformAdmin from the session to allow platform admins to set Ready for Review.

Improves error messaging for GCP Security Command Center. Adds explicit handling for SCC Legacy deprecation and for projects where the SCC API is not enabled (both in the API GCPSecurityService and the GCP integration package).

Also includes small correctness/maintenance tweaks: recursive “comment has content” detection, marks the access-request evidence form as optional, bumps device-agent electron, and removes next from @trycompai/email deps/lockfile.

^{Written by Cursor Bugbot for commit da6ab06. This will update automatically on new commits. Configure here.}

vercel · 2026-03-31T14:13:03Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
app (staging)	Ready	Preview, Comment	Mar 31, 2026 9:35pm
comp-framework-editor	Ready	Preview, Comment	Mar 31, 2026 9:35pm
portal (staging)	Ready	Preview, Comment	Mar 31, 2026 9:35pm

Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>

cursor · 2026-03-31T14:16:48Z

apps/api/src/cloud-security/providers/gcp-security.service.ts

+          'The Security Command Center API is not enabled for this project. ' +
+            'Enable it in the GCP console: APIs & Services > Enable APIs > Security Command Center API.',
+        );
+      }


Specific GCP error checks unreachable due to ordering

Medium Severity

The new checks for Security Command Center Legacy and Security Command Center API has not been used are placed after the existing PERMISSION_DENIED/403 check. GCP API error responses typically embed the HTTP status code and gRPC status in the response body JSON, so these errors will almost always contain "403" or "PERMISSION_DENIED", causing the generic handler to match first. The more specific and helpful error messages will never be shown to users. The companion file packages/integrations/src/gcp/src/index.ts doesn't have this issue because it has no 403 catch-all.

Additional Locations (1)

apps/api/src/cloud-security/providers/gcp-security.service.ts#L118-L126

The `next` package was listed as a dependency in `packages/email` but was never imported or used anywhere in the package. It is not a peer dependency of any of the package's actual dependencies (react-email, resend, etc.). Removing it to avoid unnecessary dependency maintenance. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Bumps the npm_and_yarn group with 1 update in the /packages/device-agent directory: [electron](https://github.com/electron/electron). Updates `electron` from 33.4.0 to 35.7.5 - [Release notes](https://github.com/electron/electron/releases) - [Commits](electron/electron@v33.4.0...v35.7.5) --- updated-dependencies: - dependency-name: electron dependency-version: 35.7.5 dependency-type: direct:development dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>

cursor · 2026-03-31T15:02:12Z

packages/integrations/src/gcp/src/index.ts

+              'Security > Security Command Center > Settings.',
+          );
+        }
+


Missing "API not enabled" error check in integration

Low Severity

The gcp-security.service.ts file adds both a "Security Command Center Legacy" and a "Security Command Center API has not been used" error check, but packages/integrations/src/gcp/src/index.ts only adds the "Legacy" check. Both services call the same GCP Security Command Center API endpoint and can encounter both errors. Users of the integration package will get a generic "Failed to fetch findings" message instead of the helpful guidance about enabling the API.

Additional Locations (1)

apps/api/src/cloud-security/providers/gcp-security.service.ts#L135-L141

…2404) * fix(app): pass isPlatformAdmin value to FindingItem to make 'Ready for Review' enabled by client * fix(app): remove isAuditor and add canSetReadyForReview param to FindingItem * fix(app): remove isPlatformAdmin prop from FindingItem --------- Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>

Ramp integration is no longer needed. This removes all Ramp-related code across the stack: manifest, API services/controllers, sync endpoints, frontend components (role mapping UI, sync provider), and scheduled sync. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

- Auto-clear employeeSyncProvider if the manifest no longer exists (covers orgs that had Ramp configured before removal) - Guard Image component against empty src when provider logo is missing Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Generic manifest check would break dynamic providers during transient registry gaps. Scope to explicit 'ramp' check instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Remove Ramp integration

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

cursor · 2026-03-31T21:36:23Z

apps/api/src/integration-platform/controllers/sync.controller.ts

+        data: { employeeSyncProvider: null },
+      });
+      return { provider: null };
+    }


Ramp provider is forcibly unset on reads

Low Severity

getEmployeeSyncProvider always clears employeeSyncProvider when it equals 'ramp'. This mutates state during a read and wipes a valid provider selection if a sync-capable dynamic provider uses the ramp slug, causing the provider to reset to null unexpectedly.

github-actions bot and others added 2 commits March 30, 2026 22:55

chore: merge release v3.13.1 back to main [skip ci]

8b8e2fc

chore: update error logs for GCP

90283b6

[dev] [Marfuen] mariano/eng-198-error-trying-to-run-cloud-tests

github-actions bot added prod-deploy automated-pr labels Mar 31, 2026

fix(company): make Access Request form options in Documents (#2369)

f461c4d

Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>

fix(app): comment button gets disabled with numbered formatting (#2368)

0586dfe

Co-authored-by: chasprowebdev <chasgarciaprowebdev@gmail.com> Co-authored-by: Mariano Fuentes <marfuen98@gmail.com>

vercel bot deployed to Preview – comp-framework-editor March 31, 2026 14:15 View deployment

cursor bot reviewed Mar 31, 2026

View reviewed changes

vercel bot deployed to staging – app March 31, 2026 14:17 View deployment

vercel bot deployed to staging – portal March 31, 2026 14:17 View deployment

vercel bot deployed to Preview – comp-framework-editor March 31, 2026 14:58 View deployment

vercel bot temporarily deployed to staging – portal March 31, 2026 14:59 Inactive

vercel bot temporarily deployed to staging – app March 31, 2026 14:59 Inactive

vercel bot deployed to Preview – comp-framework-editor March 31, 2026 15:00 View deployment

cursor bot reviewed Mar 31, 2026

View reviewed changes

vercel bot temporarily deployed to staging – portal March 31, 2026 16:04 Inactive

vercel bot deployed to Preview – comp-framework-editor March 31, 2026 16:05 View deployment

vercel bot deployed to staging – app March 31, 2026 16:06 View deployment

tofikwest and others added 4 commits March 31, 2026 16:53

fix: scope stale provider cleanup to ramp only

a3313cd

Generic manifest check would break dynamic providers during transient registry gaps. Scope to explicit 'ramp' check instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Merge pull request #2408 from trycompai/tofik/remove-ramp-integration

da6ab06

Remove Ramp integration

vercel bot deployed to Preview – comp-framework-editor March 31, 2026 21:33 View deployment

vercel bot deployed to staging – portal March 31, 2026 21:34 View deployment

vercel bot deployed to staging – app March 31, 2026 21:35 View deployment

cursor bot reviewed Mar 31, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[comp] Production Deploy#2406

[comp] Production Deploy#2406
github-actions[bot] wants to merge 11 commits intoreleasefrom
main

github-actions bot commented Mar 31, 2026

Uh oh!

cursor bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

vercel bot commented Mar 31, 2026 •

edited

Loading

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

cursor bot left a comment

Uh oh!

cursor bot Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

github-actions bot commented Mar 31, 2026

Uh oh!

cursor bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

vercel bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Specific GCP error checks unreachable due to ordering

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Missing "API not enabled" error check in integration

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor bot Mar 31, 2026

Choose a reason for hiding this comment

Ramp provider is forcibly unset on reads

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cursor bot commented Mar 31, 2026 •

edited

Loading

vercel bot commented Mar 31, 2026 •

edited

Loading