Conversation
fix: skip audit log for chat history and expose task templates to reg…
PR SummaryMedium Risk Overview Shifts frontend behavior to use API-backed people/task operations. The app’s remove-employee server action now deactivates members and updates roles via Reduces audit noise for assistant chat history. Marks assistant chat Written by Cursor Bugbot for commit 17378d9. This will update automatically on new commits. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| }); | ||
|
|
||
| return templates; | ||
| } |
There was a problem hiding this comment.
Duplicated task template query logic across services
Low Severity
TasksService.getTaskTemplates() duplicates the query logic from TaskTemplateService.findAll() — same table, same orderBy, same where clause structure filtering by frameworkId. The only difference is findAll additionally includes controlTemplates. Rather than duplicating, the controller could reuse TaskTemplateService (or extract a shared query method) to avoid the two implementations drifting apart over time.
* fix(auth): use better-auth APIs instead of direct DB session operations - remove-employee.ts: Replace direct db.member.delete + db.session.deleteMany with API calls (DELETE /v1/people/:id and PATCH /v1/people/:id). The API handles session cleanup, assignment clearing, and notifications properly. - people.service.ts: Replace db.session.deleteMany with auth.api.revokeUserSessions to go through better-auth's session management instead of bypassing it with direct DB writes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix(auth): revert people.service session deletion to direct DB call auth.api.revokeUserSessions requires admin middleware with an authenticated session context, which isn't available in a NestJS service. Since the API server IS the auth server, and better-auth's own revokeUserSessions internally just calls deleteSessions (same as db.session.deleteMany), direct DB access is the correct approach here. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Mariano Fuentes <marfuen98@gmail.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🎉 This PR is included in version 3.12.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
2 participants
This is an automated pull request to release the candidate branch into production, which will trigger a deployment.
It was created by the [Production PR] action.