Skip to content

feat(integrations): prompt user to import after provider connection#2383

Open
tofikwest wants to merge 2 commits intomainfrom
eng-114-prompt-import-after-google-workspace
Open

feat(integrations): prompt user to import after provider connection#2383
tofikwest wants to merge 2 commits intomainfrom
eng-114-prompt-import-after-google-workspace

Conversation

@tofikwest
Copy link
Copy Markdown
Contributor

Summary

  • After connecting a sync-capable provider (Google Workspace, Rippling, JumpCloud, Ramp), shows a toast prompting users to import their team members from People > All
  • Toast has a 15-second duration with a "Go to People" action button that navigates directly
  • Covers both OAuth callback and non-OAuth (API key) connection paths
  • Generalized for all sync-capable providers, not just Google Workspace

Test plan

  • Unit tests added (2 tests: positive for Google Workspace, negative for non-sync providers)
  • Connect Google Workspace — verify import prompt toast appears
  • Connect a non-sync provider (e.g., GitHub) — verify no import prompt
  • Click "Go to People" button — verify navigation to People > All

Resolves ENG-114

🤖 Generated with Claude Code

…ection

Resolves ENG-114

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@linear
Copy link
Copy Markdown

linear bot commented Mar 30, 2026

@cursor
Copy link
Copy Markdown

cursor bot commented Mar 30, 2026

PR Summary

Low Risk
Low risk UI-only change that adds informational toasts and a navigation action after successful provider connection. Main risk is incorrect provider targeting or unexpected routing/toast behavior in the integrations page.

Overview
After a successful connection of employee-sync capable providers (google-workspace, rippling, jumpcloud, ramp), PlatformIntegrations now shows a 15s toast.info prompting users to import team members, with a Go to People action that routes to /${orgId}/people/all.

This prompt is triggered in both the non-OAuth connect-dialog success path and the OAuth callback path (in addition to the existing success toast). Unit tests were updated/added to mock useRouter and assert the prompt appears for Google Workspace but not for non-sync providers like GitHub.

Written by Cursor Bugbot for commit 457e5a0. This will update automatically on new commits. Configure here.

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 30, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Mar 30, 2026 10:08pm
comp-framework-editor Ready Ready Preview, Comment Mar 30, 2026 10:08pm
portal Ready Ready Preview, Comment Mar 30, 2026 10:08pm

Request Review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

onClick: () => router.push(`/${orgId}/people/all`),
},
});
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated employee sync toast logic across two paths

Low Severity

The employee sync import prompt toast.info call is identically duplicated in handleConnectDialogSuccess and the OAuth callback useEffect. Both share the same message template, description, duration, and action configuration. If the toast content, duration, or navigation target changes, both sites need independent updates, risking inconsistency. Extracting a small helper like showEmployeeSyncPrompt(providerName) would keep the logic in one place.

Additional Locations (1)
Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants