feat(people): add status filter to team members page#2379
feat(people): add status filter to team members page#2379
Conversation
- Add `deactivated` field to API response (MEMBER_SELECT + PeopleResponseDto) so the client can properly distinguish deactivated vs inactive members - Extract filtering logic from TeamMembersClient into testable pure functions (buildDisplayItems, filterDisplayItems) in filter-members.ts - Replace lucide-react Loader2 with InProgress from @trycompai/design-system/icons - Add deactivated field to client-side PeopleResponseDto - Add API test for includeDeactivated query parameter - Add 17 unit tests covering status/search/role filter combinations Resolves SALE-6 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PR SummaryMedium Risk Overview Refactors and tests People page filtering. Written by Cursor Bugbot for commit 8318695. This will update automatically on new commits. Configure here. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary
deactivatedfield in the People API response so the client can properly distinguish between deactivated and inactive membersTeamMembersClientinto pure functions (buildDisplayItems,filterDisplayItems) in a newfilter-members.tsmodulelucide-reactLoader2icon withInProgressfrom@trycompai/design-system/iconsdeactivatedfield to client-sidePeopleResponseDtotypeTest plan
filterDisplayItemsandbuildDisplayItemscovering:includeDeactivated=truequery parameterResolves SALE-6
🤖 Generated with Claude Code