[INS-202] Add rate limiting to the Github Analyzer #4617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR resolves #4570 by adding a rate limiter for the Github analyzer.
I have taken a generalized approach by refactoring
NewAnalyzeClientto support a generalized and extensible HTTP client construction model using composableClientOptionsand customRateLimitRoundTripperwrapper. This approach preserves existing analyzer and logging behavior while making it easy to layer additional functionality, such as HTTP-level rate limiting for the GitHub analyzer. This means enabling this functionality for other analyzers is as simple as creating the appropriate*rate.Limiterand supplying it to the client.The integration tests were failing because the token in our secrets vault had expired. I regenerated the token and replaced it.
Checklist:
make test-community)?make lintthis requires golangci-lint)?